Broadcast tracker script config updates #5806
Conversation
|
| require Logger | ||
|
|
||
| @spec broadcast_put(any(), Keyword.t()) :: :ok | ||
| @spec broadcast_put(any(), any(), Keyword.t()) :: :ok |
|
|
||
| def broadcast_script_update(tracker_script_configuration), | ||
| do: | ||
| PlausibleWeb.TrackerScriptCache.broadcast_put( |
There was a problem hiding this comment.
minor, just noticed this - by convention, *Web namespace if for HTTP things. Cache is completely agnostic in that sense, even if Web things are its clients.
There was a problem hiding this comment.
Thanks, I hadn't considered the namespace question. At the moment we have the script at Plausible.Site.TrackerScriptConfiguration. By following existing naming principles, its Cache should be at Plausible.Site.TrackerScriptConfiguration.Cache, correct?
There was a problem hiding this comment.
Ah damn, it's not so straightforward. It caches the script, not the configuration. The script's module is PlausibleWeb.Tracker. So PlausibleWeb.Tracker.Cache or refactor also PlausibleWeb.Tracker to Plausible.Tracker?
There was a problem hiding this comment.
refactor also PlausibleWeb.Tracker to Plausible.Tracker
Probably this, but we can live with not doing it
| end | ||
|
|
||
| defp cache_content(tracker_script_configuration) do | ||
| def cache_content(tracker_script_configuration) do |
There was a problem hiding this comment.
a bit unclear what is this function for. returns either always true or some string for CE? And build_script for CE does eex-like string replace but not using EEx? Very confusing. 🤔
There was a problem hiding this comment.
Thanks! Agreed that this could use a comment. Will put something like the following:
On EE, we cache that this particular script exists to prevent Postgres stress from lookups of non-existent script IDs. The heavy lifting of caching is left to the CDN. If the ID exists, we always generate a fresh version of the script.
On CE, since we don't anticipate them using a CDN, we cache the rendered script.
Regarding the CE solution, it means that every refresh interval, every script is re-rendered by the server. This doesn't seem ideal actually.
Regarding building the script, we planned to use EEx but there were issues. There's a discussion on the PR that introduced it.
There was a problem hiding this comment.
Regarding the CE solution, it means that every refresh interval, every script is re-rendered by the server. This doesn't seem ideal actually.
Just realised that only every updated script is re-rendered by the server on CE. That's not a problem.
2 participants
Changes
Broadcasts tracker script config creates / updates to other app nodes, reducing the time between creating / updating a script and being able to reliably receive it.
Tests
Changelog
Documentation
Dark mode