Skip to content

deploy docs only on push to master - #1630

Merged
petschki merged 1 commit into
masterfrom
fix-docs-deploy-guard
Aug 25, 2026
Merged

deploy docs only on push to master#1630
petschki merged 1 commit into
masterfrom
fix-docs-deploy-guard

Conversation

@petschki

Copy link
Copy Markdown
Member

The deploy step also ran on pull_request events and published the PR build to gh_docs_deploy. Since the branch got protected, the push is rejected and every PR fails the docs job. Skip the deploy for PR builds; they only need to verify that the docs build.

  • I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
  • I verified there aren't any other open pull requests for the same change.
  • I followed the guidelines in Contributing to Plone.
  • I successfully ran code quality checks on my changes locally.
  • I successfully ran tests on my changes locally.
  • If needed, I added new tests for my changes.
  • If needed, I added documentation for my changes.
  • I included a change log entry in my commits.

If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #

The deploy step also ran on pull_request events and published the
PR build to gh_docs_deploy. Since the branch got protected, the push
is rejected and every PR fails the docs job. Skip the deploy for PR
builds; they only need to verify that the docs build.
@petschki
petschki merged commit 580cd92 into master Aug 25, 2026
3 checks passed
@petschki
petschki deleted the fix-docs-deploy-guard branch August 25, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant