Use newer acorn version for building, to support newer JS syntax#7478
Merged
Use newer acorn version for building, to support newer JS syntax#7478
acorn version for building, to support newer JS syntax#7478Conversation
emilykl
changed the title
acorn version for bundling, to support newer JS syntaxacorn version for building, to support newer JS syntax
archmoj
reviewed
Jul 18, 2025
| "virtual-webgl": "^1.0.6" | ||
| }, | ||
| "overrides": { | ||
| "falafel": { |
Contributor
There was a problem hiding this comment.
Alternatively we should propose a PR to falafel repository.
But the repository seems missing at https://github.com/substack/node-falafel
Contributor
There was a problem hiding this comment.
npm ls falafel
plotly.js
├─┬ browserify-transform-tools@1.7.0
│ └── falafel@2.2.5 deduped
├── falafel@2.2.5 overridden
└─┬ regl-scatter2d@3.3.1
└─┬ glslify@7.1.1
└── falafel@2.2.5 dedupedThis looks fine.
Also
npm run preversionpasses.
Contributor
Author
There was a problem hiding this comment.
Yeah I haven't been able to track down the falafel repository anywhere online.
Maybe we should switch away from falafel entirely?
A quick Google search brings up https://github.com/loilo/yufka as a possible replacement but it's not widely used at all.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7477
Adds an override to
package.jsonso that we use a newer version ofacornfor building Plotly.js, which allows the use of some newer JS syntax which otherwise fails (see discussion in #7474).We still target 2016 JS for the build output.