Conversation
emilykl
approved these changes
Jul 22, 2025
Contributor
emilykl
left a comment
emilykl
left a comment
There was a problem hiding this comment.
Could you add one sentence to the PR description explaining the effect this change has for the end user? (i.e. was editing fully broken before? or it wouldn't save? etc.)
LGTM.
archmoj
commented
Jul 22, 2025
| if(prop === 'title.text') editAttr = 'titleText'; | ||
| else if(prop.indexOf('axis') !== -1) editAttr = 'axisTitleText'; | ||
| else if(prop.indexOf('colorbar' !== -1)) editAttr = 'colorbarTitleText'; | ||
| else if(prop.indexOf('colorbar') !== -1) editAttr = 'colorbarTitleText'; |
Contributor
Author
There was a problem hiding this comment.
I was not able to replicate a bug as a result of this typo.
The typo was present since 2017 from b4e26ae.
The last condition would translate to
else if(prop.indexOf(true)) editAttr = 'colorbarTitleText';Which is obliviously not what we wanted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.