feat: browseruse CLI#3722
Conversation
Greptile SummaryThis PR introduces a
Confidence Score: 3/5The core logic is sound and well-tested, but the browser sidecar has no startup probe — meaning the browseruse container will race against an unready CDP endpoint and restart-loop on every new pod until the browser is actually serving. The browser sidecar container has no startup probe, so Kubernetes marks it ready immediately. The browseruse container starts right after and tries to connect to CDP on port 3000, but the browser is not necessarily serving yet — causing browseruse to fail its own startup probe repeatedly and restart-loop on every enabled pod. The hardcoded image tag will also drift silently from the CD pipeline whenever a new version is published. go/deployment-operator/internal/controller/agentrun_pod.go — the enableBrowser and enableBrowserUse functions need a startup probe on the browser sidecar to prevent restart loops.
|
| Filename | Overview |
|---|---|
| go/deployment-operator/internal/controller/agentrun_pod.go | Adds enableBrowserUse() to append a browser-use MCP sidecar init container; browser sidecar has no startup probe so browseruse can race on CDP port 3000, and the new container has no resource requests/limits; tag is hardcoded to 0.1.0 |
| go/deployment-operator/internal/controller/agentrun_pod_test.go | Good test coverage for the new sidecar; port 8082 is hardcoded as a string literal instead of referencing the constant |
| .github/workflows/deployment-operator-cd-browser-use.yaml | New CD pipeline for the browser-use sidecar image; BROWSER_USE_DEFAULT_VERSION matches the hardcoded tag in the controller but the two must be kept in sync manually |
| go/deployment-operator/dockerfiles/browser-use/Dockerfile | Clean Dockerfile for the browser-use MCP sidecar; runs as non-root (UID 65532), uses tini as init, installs browser-use at a pinned version |
| go/deployment-operator/pkg/common/mcp.go | Adds BrowserUseMCPServerPort (8082) and BrowserUseMCPServerURL constants for the browser-use MCP server |
| priv/repo/migrations/20260615032400_add_agent_runtime_browser_enabled.exs | Adds browser_enabled boolean column to agent_runtimes with NOT NULL default false; safe migration |
| lib/console/schema/agent_runtime.ex | Adds browser_enabled field with default false; correctly included in @Valid changeset fields |
| go/deployment-operator/pkg/agentrun-harness/tool/claude/claude.go | Conditionally registers the browser MCP server and allows browser tools when BrowserEnabled; consistent with existing pattern |
| go/deployment-operator/pkg/agentrun-harness/tool/codex/codex.go | Adds browser MCP server entry with TrustPolicy always when BrowserEnabled; consistent with the plural MCP entry |
| go/deployment-operator/pkg/agentrun-harness/tool/gemini/gemini.go | Passes BrowserEnabled and BrowserMCPURL into the settings template; straightforward |
| go/deployment-operator/pkg/agentrun-harness/tool/opencode/opencode.go | Passes BrowserEnabled and BrowserMCPURL into the OpenCode config template; consistent pattern |
Comments Outside Diff (2)
-
go/deployment-operator/internal/controller/agentrun_pod.go, line 562-599 (link)Browser sidecar has no startup probe —
browseruseraces against an unready CDP endpointenableBrowserappends the browser sidecar with no startup or readiness probe, so Kubernetes considers it "started" the moment the container process launches.enableBrowserUseis called immediately after, and since thebrowserusesidecar's startup probe only checks port 8082 (its own MCP listener), it will fail untilbrowser-use --mcpsuccessfully connects to CDP on port 3000 — which requires the browser container to be ready first. In practice this meansbrowseruserepeatedly crashes its startup probe (30 × 2 s = 60 s window), gets killed, and restarts in a loop until the browser sidecar is actually serving CDP. Adding aTCPSocketstartup probe ondefaultContainerBrowserServerPort(3000) to the browser container inenableBrowserwould let Kubernetes gate thebrowserusestart until the browser is actually ready. -
go/deployment-operator/internal/controller/agentrun_pod.go, line 424-426 (link)Hardcoded image tag will drift from the CD pipeline
defaultBrowseruseTag = "0.1.0"is duplicated in the CI workflow (BROWSER_USE_DEFAULT_VERSION: 0.1.0). Every time the CD pipeline bumps the browser-use image version, this constant must also be updated manually in the operator code or all runtimes will keep pulling the old image. Consider reading the tag from a configurable field (e.g. theAgentRuntimespec or an operator-level config map) rather than a compile-time constant.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Reviews (1): Last reviewed commit: "browseruse CLI" | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| pod.Spec.InitContainers = append(pod.Spec.InitContainers, corev1.Container{ | ||
| Name: browseruseContainerName, | ||
| Image: image, | ||
| SecurityContext: ensureDefaultContainerSecurityContext(nil), | ||
| RestartPolicy: lo.ToPtr(corev1.ContainerRestartPolicyAlways), | ||
| Args: []string{ | ||
| "--mcp", | ||
| "--cdp-url", fmt.Sprintf("http://127.0.0.1:%d", defaultContainerBrowserServerPort), | ||
| "--port", fmt.Sprintf("%d", common.BrowserUseMCPServerPort), | ||
| }, | ||
| Ports: []corev1.ContainerPort{ | ||
| { | ||
| Name: "browseruse", | ||
| ContainerPort: int32(common.BrowserUseMCPServerPort), | ||
| }, | ||
| }, | ||
| StartupProbe: &corev1.Probe{ | ||
| ProbeHandler: corev1.ProbeHandler{ | ||
| TCPSocket: &corev1.TCPSocketAction{ | ||
| Port: intstr.FromInt32(int32(common.BrowserUseMCPServerPort)), | ||
| }, | ||
| }, | ||
| PeriodSeconds: 2, | ||
| FailureThreshold: 30, | ||
| }, | ||
| }) |
There was a problem hiding this comment.
browseruse sidecar
The container spec omits Resources, leaving the pod's QoS class potentially degraded and giving the scheduler no signal for bin-packing. The browser sidecar (enableBrowser) lets callers pass resource overrides via browserConfig.Container.Resources, but enableBrowserUse provides no equivalent. At minimum, sensible default requests should be set so the pod doesn't land in the BestEffort class alongside the browser and DinD sidecars.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| assert.Contains(t, bu.Args, "--port") | ||
| assert.Contains(t, bu.Args, "8082") | ||
|
|
||
| if assert.Len(t, bu.Ports, 1) { |
There was a problem hiding this comment.
"8082" for the --port arg instead of deriving it from common.BrowserUseMCPServerPort. If the constant ever changes, this assertion silently passes while the probe and port declaration still use the old value.
| assert.Contains(t, bu.Args, "--port") | |
| assert.Contains(t, bu.Args, "8082") | |
| if assert.Len(t, bu.Ports, 1) { | |
| assert.Contains(t, bu.Args, "--port") | |
| assert.Contains(t, bu.Args, fmt.Sprintf("%d", common.BrowserUseMCPServerPort)) | |
| if assert.Len(t, bu.Ports, 1) { |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
1 participant
Test Plan
Test environment:
https://console.kinjal-gitgud.onplural.sh/
Checklist
Plural Flow: console