fix: setAtom uses stale pending on atom unmount #2811
+35
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
dmaskasky
force-pushed
the
fix/mount-unmount-subscribe
branch
from
aac8cc5
to
c5bcf50
Compare
dmaskasky
force-pushed
the
fix/mount-unmount-subscribe
branch
from
c5bcf50
to
20186ff
Compare
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/3FR5Y8LMQ |
See documentations for usage instructions.
dmaskasky
force-pushed
the
fix/mount-unmount-subscribe
branch
from
20186ff
to
5fbd60e
Compare
dmaskasky
force-pushed
the
fix/mount-unmount-subscribe
branch
from
5fbd60e
to
497cdd4
Compare
dmaskasky
force-pushed
the
fix/mount-unmount-subscribe
branch
from
497cdd4
to
90d104c
Compare
dmaskasky
force-pushed
the
fix/mount-unmount-subscribe
branch
from
90d104c
to
b16f8de
Compare
dmaskasky
force-pushed
the
fix/mount-unmount-subscribe
branch
from
b16f8de
to
fe1d454
Compare
dmaskasky
force-pushed
the
fix/mount-unmount-subscribe
branch
from
fe1d454
to
cbd63ec
Compare
dmaskasky
changed the title
dmaskasky
force-pushed
the
fix/mount-unmount-subscribe
branch
from
cbd63ec
to
1d18417
Compare
dmaskasky
force-pushed
the
fix/mount-unmount-subscribe
branch
from
1d18417
to
1d1dd57
Compare
dmaskasky
commented
Nov 12, 2024
dmaskasky
commented
Nov 12, 2024
dmaskasky
force-pushed
the
fix/mount-unmount-subscribe
branch
from
1d1dd57
to
687380e
Compare
|
can't reopen. can't change the base branch. 😢 |
|
now, it's reopened. can you please resolve conflicts? |
dmaskasky
force-pushed
the
fix/mount-unmount-subscribe
branch
from
1a0cb4e
to
0f0e1a2
Compare
dmaskasky
force-pushed
the
fix/mount-unmount-subscribe
branch
from
0f0e1a2
to
2e41018
Compare
dmaskasky
force-pushed
the
fix/mount-unmount-subscribe
branch
from
aa9cdb2
to
1d44255
Compare
Commit 2 changes this to use a mutable setAtom reference instead. Its cleaner but it adds an extra function call to the stack. |
|
Cool. I was thinking of hiding |
dmaskasky
force-pushed
the
fix/mount-unmount-subscribe
branch
from
116bb80
to
bec7841
Compare
|
commit 6 adds a createRuntime to clean up the code a little more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Bug Reports or Discussions
setAtom uses stale pending on atom unmount (#2812)
Why is setAtom using a stale reference of pending?
Because setAtom is defined in mountAtom and references that function's pending.
Fix: dependency inject the current pending when invoking the pending functions
Check List
pnpm run prettierfor formatting code and docs