ch4/ofi: tolerate transient CQ errors during MPI_Finalize#7763
Draft
Growl1234 wants to merge 2 commits intopmodels:mainfrom
Draft
ch4/ofi: tolerate transient CQ errors during MPI_Finalize#7763Growl1234 wants to merge 2 commits intopmodels:mainfrom
Growl1234 wants to merge 2 commits intopmodels:mainfrom
Conversation
hzhou
reviewed
Apr 7, 2026
src/mpid/ch4/netmod/ofi/ofi_events.c
Outdated
| MPIR_ERR_SETFATALANDJUMP2(mpi_errno, MPI_ERR_OTHER, "**ofid_poll", | ||
| "**ofid_poll %s %s", | ||
| MPIDI_OFI_DEFAULT_NIC_NAME, fi_strerror(errno)); | ||
| } |
Contributor
There was a problem hiding this comment.
The abort behavior is controlled by error handler at the top of the call stack, in this case, MPI_Finalize. You can intercept the error return at any of the call stack layer before returning to MPI_Finalize, as in your following changes. There is no need for changes here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
When MPI_Finalize tears down OFI resources,
fi_cq_readmay return transient I/O errors (e.g. -FI_EIO) due to race conditions with endpoint/connection shutdown. Currentlyhandle_cq_errortreats ALL unexpected CQ errors as fatal, causing an abort even though all user communication has already completed successfully.This patch:
This should take care of and resolve #7760.
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.