Add spfx-install script with metadata and details #826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Don, I see this is draft, do you need any help? |
|
I don't think so. I filled everything out, but wanted to review one more time before submitting. Honestly, I was waiting until May 1st to get one of those sweet May badges! 🙂
…________________________________
From: Paul Bullock ***@***.***>
Sent: Wednesday, April 30, 2025 2:19 AM
To: pnp/script-samples ***@***.***>
Cc: Don Kirkham ***@***.***>; Author ***@***.***>
Subject: Re: [pnp/script-samples] Add spfx-install script with metadata and details (PR #826)
[https://avatars.githubusercontent.com/u/8781041?s=20&v=4]pkbullock left a comment (pnp/script-samples#826)<#826 (comment)>
Hey Don, I see this is draft, do you need any help?
—
Reply to this email directly, view it on GitHub<#826 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACB3AT3XQ7PUMEXPHTC2FBT24B2QLAVCNFSM6AAAAAB3ZLYDVSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNBRGA2DKMJSGI>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
No worries, lol those badges are SWEET! |
|
OK, I made a change to include the latest SPFx version and submitted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I updated everything correctly. Let me know if I need to change anything.