chore: update bootc extension to 1.6.0 #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrage
requested review from
jeffmaury and
axel7083
and removed request for
a team
|
DO NOT MERGE UNTIL QE APPROVAL |
cdrage
force-pushed
the
update-bootc-160
branch
from
21c7a86 to
b4c3799
Compare
|
Biggest difference is the switch to @benoitf I'm assuming the switch will not break anything since it's still a valid ociURL. |
|
yes it'll still be ok |
benoitf
reviewed
Dec 19, 2024
static/api/extensions.json
Outdated
| @@ -468,6 +468,27 @@ | |||
| "categories": ["Containers"], | |||
| "keywords": ["bootc", "bootable", "OS", "disk"], | |||
| "versions": [ | |||
| { | |||
| "version": "1.6.0", | |||
| "podmanDesktopVersion": "^1.12.0", | |||
There was a problem hiding this comment.
should we bump the required version there to a more recent one ? like 1.14 ?
There was a problem hiding this comment.
not really required to be honest since we don't rely on any 1.14+ features, but yeah... may be good to get people to upgrade.
Updates bootc extension to 1.6.0 Signed-off-by: Charlie Drage <[email protected]>
cdrage
force-pushed
the
update-bootc-160
branch
from
b4c3799 to
12943c7
Compare
benoitf
approved these changes
Dec 20, 2024
|
@benoitf Approved by QE from Slack, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: update bootc extension to 1.6.0
Updates bootc extension to 1.6.0
Signed-off-by: Charlie Drage [email protected]