Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adapt code from eslint-plugin-svelte 3.0.x rules #329

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import { beforeEach, describe, expect, test, vi } from 'vitest';

import catalogOfExtensions from '../../static/api/extensions.json';
import type { CatalogExtensionInfo } from './api/extensions-info';
import { catalogExtensions, getCurrentExtension, initCatalog, setCurrentExtension } from './extensions.svelte';
import { catalogExtensions, getCurrentExtension, initCatalog, setCurrentExtension } from './extensions';

const fetchMock = vi.fn();

Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion src/lib/ui/ExtensionByCategoryCard.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import { fireEvent, render, screen } from '@testing-library/svelte';
import { beforeEach, expect, test, vi } from 'vitest';

import type { CatalogExtensionInfo } from '$lib/api/extensions-info';
import { getCurrentExtension } from '$lib/extensions.svelte';
import { getCurrentExtension } from '$lib/extensions';

import ExtensionByCategoryCard from './ExtensionByCategoryCard.svelte';

Expand Down
2 changes: 1 addition & 1 deletion src/lib/ui/ExtensionByCategoryCard.svelte
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<script lang="ts">
import type { CatalogExtensionInfo } from '../api/extensions-info';
import { setCurrentExtension } from '../extensions.svelte';
import { setCurrentExtension } from '../extensions';
import ExtensionIcon from './ExtensionIcon.svelte';

const { extension }: { extension: CatalogExtensionInfo } = $props();
Expand Down
2 changes: 1 addition & 1 deletion src/lib/ui/ExtensionsByCategory.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const { extensionByCategoryInfo }: { extensionByCategoryInfo: ExtensionByCategor
role="region"
aria-label="Extensions of category {extensionByCategoryInfo.category}"
>
{#each extensionByCategoryInfo.extensions as extension}
{#each extensionByCategoryInfo.extensions as extension (extension.id)}
<ExtensionByCategoryCard {extension} />
{/each}
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/lib/ui/ExtensionsDetails.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import { CloseButton } from '@podman-desktop/ui-svelte';

import type { CatalogExtensionInfo } from '$lib/api/extensions-info';
import { setCurrentExtension } from '$lib/extensions.svelte';
import { setCurrentExtension } from '$lib/extensions';

import ExtensionsDetailsBottom from './ExtensionsDetailsBottom.svelte';
import ExtensionsDetailsTop from './ExtensionsDetailsTop.svelte';
Expand Down
2 changes: 1 addition & 1 deletion src/lib/ui/ExtensionsDetailsBottom.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ $effect(() => {
<th>Version</th>
<th>Released</th>
</tr>
{#each versions as version}
{#each versions as version (version.version)}
<tr>
<td>{version.version}</td>
<td>{moment(version.lastUpdated).format('YYYY-MM-DD')}</td>
Expand Down
2 changes: 1 addition & 1 deletion src/lib/ui/ExtensionsList.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const { extensionsByCategories }: { extensionsByCategories: ExtensionByCategoryI
</script>

<div class="flex flex-col h-full">
{#each extensionsByCategories as extensionByCategoryInfo}
{#each extensionsByCategories as extensionByCategoryInfo (extensionByCategoryInfo.category)}
<ExtensionsByCategory {extensionByCategoryInfo} />
{/each}
</div>
2 changes: 1 addition & 1 deletion src/routes/+page.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
import { onMount } from 'svelte';

import Appearance from '$lib/Appearance.svelte';
import { catalogExtensions, getCurrentExtension, initCatalog } from '$lib/extensions';
import ExtensionsDetails from '$lib/ui/ExtensionsDetails.svelte';
import ExtensionsList from '$lib/ui/ExtensionsList.svelte';

import type { ExtensionByCategoryInfo } from '../lib/api/extensions-info';
import { catalogExtensions, getCurrentExtension, initCatalog } from '../lib/extensions.svelte';

const uniqueCategories: string[] = $state([]);
const extensionsByCategories: ExtensionByCategoryInfo[] = $state([]);
Expand Down
2 changes: 1 addition & 1 deletion src/routes/page.svelte.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import '@testing-library/jest-dom/vitest';
import { render, screen } from '@testing-library/svelte';
import { beforeEach, expect, test, vi } from 'vitest';

import { catalogExtensions } from '$lib/extensions.svelte';
import { catalogExtensions } from '$lib/extensions';

import catalogOfExtensions from '../../static/api/extensions.json';
import Page from './+page.svelte';
Expand Down
Loading