Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reduce length of short descriptions #44

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Apr 26, 2024

Reduce length of the short descriptions which were not short.

if agreement on the title, I'll create PR to update package.json of each repository of the extensions

fixes podman-desktop/podman-desktop#6771

Change-Id: I3eb78a2100a232e3702ff9602ed73dceb1eae6ce

fixes podman-desktop/podman-desktop#6771

Change-Id: I3eb78a2100a232e3702ff9602ed73dceb1eae6ce
Signed-off-by: Florent Benoit <[email protected]>
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Would rephrase

Best of Red Hat extensions for Podman Desktop

as

Recommended Red Hat extensions for Podman Desktop

Signed-off-by: Florent BENOIT <[email protected]>
Copy link
Contributor

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -177,7 +177,7 @@
},
"extensionName": "openshift-local",
"displayName": "Red Hat OpenShift Local",
"shortDescription": "This extension provides a Red Hat OpenShift Local cluster and allows Podman Desktop to interact with it",
"shortDescription": "Run Red Hat OpenShift locally",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name is Red Hat OpenShift Local so feels odd to me to keep the Red Hat but drop Local. (like for the sandbox above we wouldn't say it's Red Hat OpenShift sign up)

Maybe keep the name (e.g. 'Run OpenShift Local on your machine'), or drop it entirely like 'Run an OpenShift cluster locally' / 'Run a local OpenShift cluster' / 'Run OpenShift locally'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would replace OpenShift by MicroShift :-)

Run MicroShift locally

@@ -311,7 +311,7 @@
},
"extensionName": "minikube",
"displayName": "minikube",
"shortDescription": "Integration for minikube: a tool that makes it easy to run Kubernetes locally",
"shortDescription": "Run Kubernetes locally",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little too generic? This could apply to OpenShift Local or Kind too. I know it's obvious beside the display name but feels like it could use something like 'Run Kubernetes locally with minikube' or something that's unique about minikube.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first I used with minikube but then in the catalog you see the name 'Minikube' and the description is to run Kubernetes so I would say it's the combination of the two. It feels redundant to say it's with minikube as it's the name of the extension

The GitHub page of minikube says Run Kubernetes locally

Signed-off-by: Florent BENOIT <[email protected]>
@benoitf benoitf merged commit c4662bd into podman-desktop:gh-pages Apr 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants