Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md for openshift local #53

Merged
merged 5 commits into from
May 14, 2024
Merged

Update README.md for openshift local #53

merged 5 commits into from
May 14, 2024

Conversation

dgolovin
Copy link
Contributor

@dgolovin dgolovin commented May 7, 2024 •
edited
Loading

@dgolovin dgolovin marked this pull request as ready for review May 7, 2024 19:33
@benoitf
Copy link
Contributor

benoitf commented May 13, 2024

need to backport the PR to https://github.com/crc-org/crc-extension as well

benoitf
benoitf approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to create a PR in crc-extension repository to make it ready for upcoming versions as well

jeffmaury
jeffmaury approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgolovin dgolovin merged commit e1cfe72 into gh-pages May 14, 2024
2 checks passed
@dgolovin dgolovin mentioned this pull request May 14, 2024
Merged
@benoitf benoitf deleted the dgolovin-crc-readme-update branch November 6, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf approved these changes

@jeffmaury jeffmaury jeffmaury approved these changes

@deboer-tim deboer-tim deboer-tim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dgolovin @benoitf @jeffmaury @deboer-tim