Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump ai-lab version to 1.3.2 #95

Closed
wants to merge 1 commit into from
Closed

chore: bump ai-lab version to 1.3.2 #95

wants to merge 1 commit into from

Conversation

axel7083
Copy link
Contributor

@axel7083 axel7083 commented Nov 5, 2024

ai-lab release 1.3.2

@benoitf said in #78 (comment) that we should push to gh-page branch. If this is not the case anymore, see https://github.com/containers/podman-desktop-catalog/compare/main...axel7083:chore/bump-ai-lab-1-3-2?expand=1

benoitf
benoitf approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: needs to fix DCO check

and need someone from QE approving before merging

@axel7083 axel7083 force-pushed the chore/gh-page-bump-ai-lab-1-3-2 branch from a4b3ee5 to 09e1184 Compare November 5, 2024 15:40
@axel7083
Copy link
Contributor Author

axel7083 commented Nov 5, 2024

and need someone from QE approving before merging

Will raise the subject in the daily

@axel7083 axel7083 requested a review from ScrewTSW November 5, 2024 17:03
benoitf
benoitf requested changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now that the app to view the catalog has been merged, need to change the target branch:

--> main branch and no longer gh-pages

@axel7083
Copy link
Contributor Author

axel7083 commented Nov 7, 2024

Closing in favour of #105

@axel7083 axel7083 closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf requested changes

@ScrewTSW ScrewTSW Awaiting requested review from ScrewTSW

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axel7083 @benoitf