You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The set of sprintf-like types accepted by message_chk() has grown (%es and the %% escape in #293, alongside %n, %s, %r, %y and %ies) but the documentation has not been reviewed as a whole.
The types are documented only in ?message_chk; err(), wrn() and msg() inherit the n parameter but a reader landing on ?err has no visible list of the types.
Consider whether the section should be shared or cross-referenced.
Nothing in the README or the vignettes covers message construction; consider whether it belongs in vignettes/chk.Rmd.
Outcome: a reviewed and consistent @section sprintf-like types: block with examples that exercise every type, and cross-references from ?err.
The set of
sprintf-like types accepted bymessage_chk()has grown (%esand the%%escape in #293, alongside%n,%s,%r,%yand%ies) but the documentation has not been reviewed as a whole.Points to review:
%yentry reads'y' if n == 1 otherwise 'ie', which is only usable when followed by%s.Its relationship to
%iesis not explained (see Deprecate%yin favour of%iesinmessage_chk()#313).%%escapes a literal%and why%esis not consumed by%s.%that does not start a recognized type is left as is; this is stated but not shown in the examples.director%y%sthroughout and do not demonstrate%iesat all.napplies to the whole message (message_chk()supports only one count per message #311); the documentation does not say so.?message_chk;err(),wrn()andmsg()inherit thenparameter but a reader landing on?errhas no visible list of the types.Consider whether the section should be shared or cross-referenced.
vignettes/chk.Rmd.Outcome: a reviewed and consistent
@section sprintf-like types:block with examples that exercise every type, and cross-references from?err.