predict.fitdists() gains samples and save_to arguments - #182
Open
joethorley wants to merge 1 commit into
Open
Conversation
Fixes bcgov#452 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes bcgov#452
predict.fitdists()is a thin wrapper onssd_hc()but was missing two arguments thatssd_hc.fitdists()exposes:samplesandsave_to. They are now added (with the same defaults,samples = FALSEandsave_to = NULL) and passed straight through, sopredict()can return the bootstrap samples list-column and save the bootstrap datasets/estimates to disk.Tests
predict(..., samples = TRUE)returns asamplescolumn identical to the equivalentssd_hc()call.predict(..., save_to = dir)writes the same bootstrap data/estimate files asssd_hc().Full test suite passes locally (1349 tests, 0 failures, NOT_CRAN=true).
Note:
predict.fitburrlioz()similarly lagsssd_hc.fitburrlioz()(missingsamples/save_to, and itsparametricdefault differs). Left out of scope here since the issue targetspredict.fitdists(); happy to follow up if wanted.🤖 Generated with Claude Code