ARC support and fix all warnings and errors for Xcode 9.1 and iOS 11.1#412
Open
rivera-ernesto wants to merge 62 commits intopokeb:masterfrom
Open
ARC support and fix all warnings and errors for Xcode 9.1 and iOS 11.1#412rivera-ernesto wants to merge 62 commits intopokeb:masterfrom
rivera-ernesto wants to merge 62 commits intopokeb:masterfrom
Conversation
…nsigned long long)progress ofTotal:(unsigned long long)total;to + (void)updateProgressIndicator:(id)indicator withProgress:(unsigned long long)progress ofTotal:(unsigned long long)total;
…thObject:(id)object amount:(void *)amount callerToRetain:(id)caller; to + (void)performSelector:(SEL)selector onTarget:(id)target withObject:(id)object amount:(void *)amount callerToRetain:(id)caller;
…ug,fixed SSL issue
Collaborator
|
There’s a definite chance of this getting merged if several people comment to say that it works for them in their project & that they have also reviewed the code and found no issues. We’ll definitely not merge a pod spec unless it is very clearly marked as saying the asihttprequest is obsolete and should almost never be used. We don’t want anyone to accidentally incorporate asi into their projects. (I’d be interested to know why people are still using ASI too...!) |
Author
|
In my case I am just maintaining an old project that uses the library. If it ain't broken... And you're right. I'll add the discontinued disclaimer. |
This reverts commit b391060. # Conflicts: # Classes/ASIHTTPRequest.m
…nto whlsxl-master # Conflicts: # Classes/ASIAuthenticationDialog.m # Classes/ASIDataCompressor.m # Classes/ASIDataDecompressor.m # Classes/ASIFormDataRequest.h # Classes/ASIFormDataRequest.m # Classes/ASIHTTPRequest.h # Classes/ASIHTTPRequest.m # Classes/ASIInputStream.h # Classes/ASIInputStream.m # Classes/ASINetworkQueue.h # Classes/ASINetworkQueue.m # External/Reachability/Reachability.h # External/Reachability/Reachability.m # iPhone.xcodeproj/project.pbxproj
rivera-ernesto
changed the title
|
Nice work . man! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR includes:
• Fixes from forks by @OpenFibers (#356), @John1261, @gbanfalvikl and @whlsxl (#377).
• Fixes for all build warnings in Xcode 9.2.
• Fixes for all Analyzer warnings in Xcode 9.2.
• Tested to be working on iOS 9.0~11.1.
• Not yet working on macOS.
While this PR will more likely never be merged, anyone can use it by adding
pod 'ASIHTTPRequest', :git => 'https://github.com/codelathe/asi-http-request.git'to their Podfile.