Skip to content

Conversation

@nhussein11
Copy link
Collaborator

πŸ“ Description

Provide a clear and concise description of your changes.

πŸ” Review Preference

Choose one:

  • [] βœ… I have time to handle formatting/style feedback myself
  • ⚑ Docs team handles formatting (check "Allow edits from maintainers")

πŸ€– AI-Ready Docs

If content changed, regenerate AI files:

  • βœ… I ran python3 scripts/generate_llms.py
  • ⚑ Docs team will regenerate (check "Allow edits from maintainers")

βœ… Checklist

@nhussein11 nhussein11 self-assigned this Oct 20, 2025
@nhussein11 nhussein11 requested a review from a team as a code owner October 20, 2025 22:30
Copilot AI review requested due to automatic review settings October 20, 2025 22:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive deployment documentation for basic smart contracts to Polkadot Hub, splitting the content into two separate guides: one for PolkaVM (PVM) deployment and one for standard EVM deployment. Each guide covers four deployment methods: Ethers.js, Remix IDE, Hardhat, and Foundry.

Key Changes:

  • Created two new deployment guides with distinct tooling paths (PVM vs EVM)
  • Removed the placeholder TODO file
  • Updated navigation to reflect the new structure

Reviewed Changes

Copilot reviewed 7 out of 13 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
smart-contracts/cookbook/smart-contracts/deploy-basic.md Removed placeholder TODO file
smart-contracts/cookbook/smart-contracts/deploy-basic-pvm.md Added comprehensive PVM deployment guide using resolc compiler
smart-contracts/cookbook/smart-contracts/deploy-basic-evm.md Added comprehensive EVM deployment guide using standard Solidity compiler
smart-contracts/cookbook/smart-contracts/.nav.yml Updated navigation structure to include both PVM and EVM guides
llms.txt Regenerated AI file with updated documentation links
llms-full.txt Regenerated full AI file with complete documentation content
llms-files/llms-smart-contracts.txt Regenerated smart contracts AI file with new guides

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@brunopgalvao brunopgalvao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice read. I see four tutorials in this deploy a basic contract tutorial:

  • an Ethers.js tutorial,
  • a Remix IDE tutorial,
  • a Hardhat tutorial,
  • and a Foundry tutorial

We can move forward as is, however it would be nice to circle back to this and split this up into separate sub-pages.

@0xlukem 0xlukem added B0 - Needs Review Pull request is ready for review A0 - New Content Pull request contains new content pages labels Oct 23, 2025
@0xlukem 0xlukem requested a review from eshaben October 23, 2025 18:32
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only really reviewed the ethers.js guide and quickly looked at the other ones. My comments apply to all the guides, so please go back through and make the updates to those pages too. Thanks!

In smart-contracts/get-started.md we have a reference to [Deploy a Basic Contract](/smart-contracts/cookbook/smart-contracts/deploy-basic/), can you please update the link to point to the first guide in this section?

@0xlukem 0xlukem requested a review from eshaben October 30, 2025 16:57
@0xlukem 0xlukem requested a review from eshaben October 31, 2025 16:28
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last few things

Copy link
Contributor

@0xlukem 0xlukem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xlukem 0xlukem added B1 - Ready to Merge Pull request is ready to be merged and removed B0 - Needs Review Pull request is ready for review labels Nov 4, 2025
@eshaben eshaben merged commit abc3875 into staging/product-ia Nov 4, 2025
3 of 4 checks passed
@eshaben eshaben deleted the nhussein11/add-deploy-basic-pvm branch November 4, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A0 - New Content Pull request contains new content pages B1 - Ready to Merge Pull request is ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants