-
Notifications
You must be signed in to change notification settings - Fork 10
Update Github Action for Publishing to Comfy Registry #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add permissions for issue writing - Restrict job execution to specific repository owner - Update action version to v1 for stability - Ensure proper token usage for registry access
Reviewer's Guide by SourceryThis pull request updates the Github Action No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @robinjhuang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using
github.repository
instead ofgithub.repository_owner
to avoid hardcoding the repository owner. - It might be better to use
GITHUB_TOKEN
instead of requiring users to create and manage aREGISTRY_ACCESS_TOKEN
.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Hey! My name is Robin and I'm from comfy-org! We would love to have you join the Comfy Registry, a public collection of custom nodes which lets authors publish nodes by version and automate testing against existing workflows. This PR updates the Github Action
publish_action.yml
to ensure the latest ComfyUI Community Standard.Updates:
+ if: ${{ github.repository_owner == 'pollockjj' }}
Learn More
Please message me on Discord at robin or join our server if you have any questions! For more information, visit the official Comfy-Org blog: ComfyUI Blog.
Summary by Sourcery
Update GitHub Action workflow for publishing to Comfy Registry with improved configuration and security
Enhancements:
CI: