Reset the manifest source list between nightly and release merges - #136
Merged
Conversation
combine-images.bash accumulated the per-arch source images in a single `sources` array shared across both merge_images calls, and never reset it. The nightly merge ran first and left nightly-amd64 and nightly-arm64 in the array; the release merge then appended release-amd64 and release-arm64 and published the release manifest from all four, nightly entries first. Docker resolves a multi-arch tag to the first image matching the host platform, so pulling any of these :release images returned the nightly build on both amd64 and arm64 -- and projects using them for release CI were compiling against nightly ponyc. Resetting the array at the start of each merge fixes every affected variant: libressl-4.2.0, libressl-4.2.1, openssl-3.6.0, openssl-3.6.2, openssl-4.0.0. The plain standard-builder and -with-pcre build multi-arch directly and were never affected.
ponylang-main
added
the
discuss during sync
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
combine-images.bashcollected the per-arch source images into onesourcesarray shared across bothmerge_imagescalls and never reset it. The nightly merge ran first and leftnightly-amd64andnightly-arm64in the array; the release merge then appendedrelease-amd64andrelease-arm64and built the release manifest from all four, with the nightly entries first.Docker resolves a multi-arch tag to the first image matching the host platform, so every affected
:releaseimage resolved to the nightly build on both amd64 and arm64. Concretely,ghcr.io/ponylang/shared-docker-ci-standard-builder-with-libressl-4.2.1:releasecurrently runsponyc nightly-20260712while its basestandard-builder:releasecorrectly runs the release,0.67.0. Its:releasemanifest lists four platform entries instead of two, nightly first. Projects using these images for release CI have been compiling against nightly ponyc.Resetting the array at the start of each
merge_imagescall fixes it. The same accumulator-not-reset pattern was in all five variants that use this combine step — libressl-4.2.0, libressl-4.2.1, openssl-3.6.0, openssl-3.6.2, openssl-4.0.0 — so all five are fixed here. The plainstandard-builderand-with-pcrebuild multi-arch directly and were never affected.Verified with a stubbed
docker: before, the release manifest is created fromnightly-amd64 nightly-arm64 release-amd64 release-arm64; after, fromrelease-amd64 release-arm64. shellcheck is clean on all five.