Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor style adjustmens #53

Merged
merged 6 commits into from
Feb 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/e2e-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
run: yarn playwright install --with-deps
- name: Run Playwright tests
run: yarn playwright test
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: always()
with:
name: playwright-report
Expand Down
1 change: 0 additions & 1 deletion content/blog/android-open-source.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ author:
description: Android is an operating system that is collectively maintained by a global community of individuals and companies. What started a decade ago as a technical foundation for nowadays around 70% of all smartphones, has quickly evolved to Swiss army knife that powers watches, televisions, and car infotainment systems.
image: https://developer.android.com/static/images/brand/android-head_flat.png
slug: https://source.android.com/
readTime: 5min
---

<ImageText imageSrc="/assets/blog/aosp/1.jpg" imageAlt="Macan, 2024, Porsche AG" theme="light" left
Expand Down
1 change: 0 additions & 1 deletion content/blog/cookie-consent-banner.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ author:
description: Simplify cookie consent with Cookie Consent Banner, providing a customizable UI and a straightforward API. Focus on the things that really matter.
image: https://raw.githubusercontent.com/porscheofficial/cookie-consent-banner/main/assets/logo.svg
slug: https://github.com/porscheofficial/cookie-consent-banner
readTime: 5min
---

<ImageText imageSrc="/assets/blog/ccb/3.png" imageAlt="The Open Source Maintainers, co-working on a laptop" theme="light"
Expand Down
1 change: 0 additions & 1 deletion content/blog/oss-review-toolkit.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ author:
description: The OSS Review Toolkit (ORT) is a Free and Open Source Software (FOSS) orchestration toolkit to – among other features – manage open-source software dependencies and ensure compliance with a configurable set of policies. The ORT project, that was later donated to the Linux Foundation, quickly gained track among the FOSS community.
image: https://raw.githubusercontent.com/oss-review-toolkit/ort/main/logos/logo.png
slug: https://oss-review-toolkit.org/ort/
readTime: 5min
---

<ImageText imageSrc="/assets/blog/ort/1.jpg" imageAlt="Taycan, 2021, Porsche AG" theme="light" left
Expand Down
1 change: 0 additions & 1 deletion content/blog/porsche-design-system.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ author:
description: The Porsche Design System provides the design fundamentals and elements for efficiently creating aesthetic and high-quality web applications, including easy-to-use Figma and UX Pin libraries, coded Web Components and comprehensive usage guidelines. Everything is built and tested following the Porsche quality standards and corporate design principles.
image: https://raw.githubusercontent.com/porsche-design-system/porsche-design-system/main/packages/assets/projects/crest/src/porsche-crest%403x.png
slug: https://designsystem.porsche.com/
readTime: 5min
---

<ImageText imageSrc="/assets/blog/pds/1.jpg" imageAlt="Marcel Bertram" theme="light"
Expand Down
1 change: 0 additions & 1 deletion content/blog/porsche-digital-campus.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ author:
description: The Porsche Digital Campus is an innovative initiative with the goal of bringing together research and real-world application in the fields of AI, machine learning, and data science.
image: https://uploads-ssl.webflow.com/6419a4c2c9609e21b02a47e8/6454e539d4ea54c08e42aedb_Frame%2010683.png
slug: https://campus.porsche.digital/
readTime: 3min
---

<ImageText imageSrc="/assets/blog/pdc/team.jpg" imageAlt="Porsche Digital Campus" theme="light"
Expand Down
11 changes: 0 additions & 11 deletions contentlayer.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,17 +51,6 @@ const Blog = defineDocumentType(() => ({
description: "The date of the blog",
required: true,
},
readTime: {
type: "string",
description: "The reading time of the blog",
required: true,
},
hashTags: {
type: "list",
of: { type: "string" },
description: "The list of hashtags of the blog",
required: false,
},
author: {
type: "nested",
of: Author,
Expand Down
9 changes: 3 additions & 6 deletions src/app/blog/[...slug]/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ export async function generateMetadata(props: {
return {
title,
description: doc.descriptionShort,
keywords: doc.hashTags?.flat(),
authors: [
{
name: doc.author?.name,
Expand Down Expand Up @@ -75,17 +74,15 @@ const BlogPage: ({
notFound();
}

const formatDate = format(parseISO(blog.date), "do LLLL yyyy");
const hashes = blog.hashTags ? `Β· #${blog.hashTags.join(" #")}` : "";
const description = `${formatDate} Β· ${blog.readTime} reading time ${hashes}`;
const formatDate = format(parseISO(blog.date), "yyyy");
const subtitle = `FOSS@Porsche Β· ${formatDate}`;
const hero = blog.hero ? blog.hero : blog.image;

return (
<main>
<HeroSection
title={blog.title}
description={description}
subtitle="FOSS@Porsche"
subtitle={subtitle}
imageSrc={hero}
imageAlt="Hero Image"
position="center center"
Expand Down
9 changes: 7 additions & 2 deletions src/components/03_organisms/blogCard/BlogCard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,13 @@ export const BlogCard: React.FC<BlogCardProps> = ({
{title}
</PHeading>
{time && (
<PText size="x-small" theme="dark" className={s.description}>
{format(parseISO(time), "LLLL d, yyyy")}
<PText
tag="span"
size="x-small"
theme="dark"
className={s.description}
>
{format(parseISO(time), "yyyy")}
</PText>
)}
<PText ellipsis size="small" theme="dark" className={s.description}>
Expand Down
13 changes: 0 additions & 13 deletions src/components/03_organisms/heroSection/HeroSection.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,12 @@ import { StaticImageData } from "next/image";
import {
PDisplay,
PHeading,
PText,
} from "@porsche-design-system/components-react/ssr";
import s from "./heroSection.module.scss";

interface HeroSectionProps {
title?: string;
subtitle?: string;
description?: string;
imageSrc: string | StaticImageData;
imageAlt: string;
position?: string;
Expand All @@ -19,7 +17,6 @@ interface HeroSectionProps {
export const HeroSection: React.FC<HeroSectionProps> = ({
title,
subtitle,
description,
imageSrc,
imageAlt,
position = "right center",
Expand Down Expand Up @@ -57,16 +54,6 @@ export const HeroSection: React.FC<HeroSectionProps> = ({
>
{title}
</PDisplay>
{description && (
<PText
size="medium"
align="center"
theme="dark"
className={s.description}
>
{description}
</PText>
)}
</div>
</div>
);
Expand Down
Loading