Add error handling to plan builder #785
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the `on_error` and `ignore_errors` methods to the PlanBuilderV2. These allow users to define custom error handling logic for individual steps, enabling more robust and resilient plan execution. The `on_error` method accepts a callable that will be executed when a step fails. If the callable returns a value, that value becomes the step's output, and execution continues. The `ignore_errors` method is a convenience function that sets the error handler to return `None`, effectively skipping over failed steps. Co-authored-by: robbie <[email protected]>
|
Cursor Agent can help with this pull request. Just |
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
Co-authored-by: robbie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces
.on_error()and.ignore_errors()methods toPlanBuilderV2, enabling granular error handling for individual steps within a plan.Motivation: Previously, any unhandled exception in a step would halt the entire plan. With these new methods, users can now define custom logic to:
on_errorhandler can return a value, which will be used as the step's output, allowing the plan to continue execution..ignore_errors()shortcut provides a simple way to swallow exceptions and proceed withNoneas the step's output.This significantly enhances the robustness and flexibility of plan execution by providing explicit control over error flow.
Ticket Link: N/A
Type of change
Screenshots
N/A
Changelog
.on_error()and.ignore_errors()toPlanBuilderV2for per-step error handling.on_errorhandlers, allowing for error recovery or explicit propagation.