Address Copilot review comments; add native uv build backend#18
Conversation
…atchling (uv default) Co-authored-by: statik <983+statik@users.noreply.github.com> Agent-Logs-Url: https://github.com/posit-dev/agentic-adoption-scan/sessions/869a17f3-bd4d-4713-a232-91f5bc4c9d04
|
@copilot i don't want to use hatchling, i want to use the native uv build backend |
Co-authored-by: statik <983+statik@users.noreply.github.com> Agent-Logs-Url: https://github.com/posit-dev/agentic-adoption-scan/sessions/c180b5f8-4d39-48a6-ae9b-eb6beee9f141
Done in 790e2e3. Replaced hatchling with [build-system]
requires = ["uv_build>=0.6.0,<0.11.0"]
build-backend = "uv_build"
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot fix the Go tests failure |
Agent-Logs-Url: https://github.com/posit-dev/agentic-adoption-scan/sessions/0e8981bd-3838-4e6e-a287-760f7b652ee3 Co-authored-by: statik <983+statik@users.noreply.github.com>
Fixed in e5ab385. |
Nine Copilot review comments on the three-layer eval framework (PR #17) — covering missing build backends, incorrect CI conditions, connection leaks, and missing graceful-skip logic.
Build system
Both
evals/inspect/pyproject.tomlandevals/connect/pyproject.tomllacked a[build-system]table, causingpip install -e .to fail in CI. Added uv's native build backend:uv_builduses a src layout and requires a Python package module, so minimalsrc/mcp_evals/__init__.pyandsrc/connect_deploy_tests/__init__.pystubs were added to satisfy that requirement.mcp_eval_tasks.pylist_indicators_qualityandadoption_agent_eval: both now return a trivial no-op/skipTaskwhenANTHROPIC_API_KEYis absent, matching the stated "skip gracefully" design.--cache-dir: subprocess now passes--cache-dir <tmpdir>on the CLI rather thanMCP_CACHE_DIR(which the Go binary does not read), isolating cache state per eval run.conftest.pyhttp_clientfixture changed fromreturntoyieldwithtry/finally → client.close()to avoid leaking connections across the test session.Workflow conditions
pr-connect-deploy.yml: jobif:now also checkssecrets.CONNECT_LICENSE != ''so the job actually skips when the secret is absent.pr-evals.yml: both LLM step conditions changed fromenv.ANTHROPIC_API_KEY != ''(always false — env vars aren't set at evaluation time) tosecrets.ANTHROPIC_API_KEY != ''.Original prompt
⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.