fix: Address slicing for pyarrow array in data_color#741
Merged
rich-iannone merged 12 commits intoposit-dev:mainfrom Mar 11, 2026
Merged
fix: Address slicing for pyarrow array in data_color#741rich-iannone merged 12 commits intoposit-dev:mainfrom
data_color#741rich-iannone merged 12 commits intoposit-dev:mainfrom
Conversation
FBruzzesi
commented
Jul 30, 2025
Contributor
Author
There was a problem hiding this comment.
I manually checked a few vs pandas/polars, but more eyes the better
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #741 +/- ##
==========================================
- Coverage 92.31% 92.31% -0.01%
==========================================
Files 48 48
Lines 6039 6052 +13
==========================================
+ Hits 5575 5587 +12
- Misses 464 465 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FBruzzesi
commented
Jul 30, 2025
|
|
||
| @get_rows.register | ||
| def _(ser: PdSeries, indexes: list[int]) -> PdSeries: | ||
| return ser.iloc[indexes] |
Contributor
Author
There was a problem hiding this comment.
I think it was intended to use index location in the first place but the issue never arise?
machow
approved these changes
Mar 11, 2026
Collaborator
machow
left a comment
There was a problem hiding this comment.
This LGTM. @rich-iannone if CI passes and it seems okay, want to merge?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up from the disclaimer section in #736
summary
> For pyarrow backed tbl_data, `data_color` the code would end up breaking a few lines down the line when performing the follow operation:In fact, slicing with a list on a chunked array raises
I wanted this PR to be atomic enough to solve one issue. I can follow up on this other one
Checklist