Skip to content

e2e: add notebook release screenshots#13651

Merged
midleman merged 8 commits into
mainfrom
mi/release-screenshots-3
May 21, 2026
Merged

e2e: add notebook release screenshots#13651
midleman merged 8 commits into
mainfrom
mi/release-screenshots-3

Conversation

@midleman
Copy link
Copy Markdown
Contributor

@midleman midleman commented May 20, 2026 •
edited
Loading

Summary

Adds 4 notebook release screenshot tests:

  • Positron notebook editor kernel selector (annotated kernel chip)
  • Positron notebook assistant action bar button (annotated)
  • Positron notebook assistant panel (full panel open)
  • Jupyter notebook kernel selector (annotated kernel chip)

Also modified full screen captures to always add the shadow box effect.

QA Notes

See updated screenshot report here.

@midleman @claude
e2e: add notebook release screenshots
9c304de 
- Positron notebook: kernel selector, assistant action bar, assistant panel
- Jupyter notebook: kernel selector

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 20, 2026 •
edited
Loading

E2E Tests 🚀
This PR will run tests tagged with: @:critical

readme  valid tags

midleman and others added 7 commits May 20, 2026 06:32
@midleman @claude
e2e: install Air extension if missing before verified-publisher scree…
821509e 
…nshot

Air ships pre-installed in some builds but not all. Install it when the
Install button is visible so the capture shows the Disable/Uninstall state
every run.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@midleman @claude
e2e: include kernel icon in jupyter-notebooks-kernel-selector annotation
5fcf43b 
Target the .kernel-action-view-item container so the codicon-notebook-kernel-select
icon stays inside the red box, matching the existing published screenshot.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@midleman @claude
e2e: shrink notebook viewport and add drop shadow halo
ce74c83 
Render the 4 notebook screenshots at 960x640 and composite each capture onto a
white canvas with a soft drop shadow to approximate the floating-window look
of the legacy macOS-chrome screenshots.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@midleman @claude
e2e: round screenshot corners and override workspace label
5b293e3 
- Clip the screenshot to a 24px-radius rounded rect before drawing the
  drop shadow so the shadow traces the rounded silhouette.
- Add overrideWorkspaceName helper to rewrite the title bar and top action
  bar folder picker, mapping qa-example-content -> positron-demos-notebooks
  on the 4 notebook captures.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@midleman @claude
e2e: rewrite notebook kernel labels to (Venv: .venv) for screenshots
0f2d728 
Extend overrideRuntimeLabel to also target the Positron notebook kernel
status badge and the VS Code Jupyter kernel chip, so the captured label
reads "Python <ver> (Venv: .venv)" instead of leaking the runner's Python
manager (Pyenv, VirtualEnvWrapper, uv, etc.).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@midleman @claude
e2e: bake drop-shadow halo into captureFullWindow
baa06dc 
Apply the rounded-corner drop shadow inside captureFullWindow itself so all
full-app screenshots get the floating-window treatment automatically (astropy,
the four notebook captures, and any future full-window shots). Partial
captures via capturePanel/captureRegion are unaffected.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@midleman @claude
e2e: move screenshot raw locators into POMs
42363be 
- Add extensions.installFromEditorIfNotInstalled() and use it from
  extension-publisher screenshot test.
- Use notebooksPositron.expectAssistantButtonsVisible() and
  clickAskAssistantButton() instead of raw locators in the notebook
  assistant screenshot tests.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
testlabauto
testlabauto approved these changes May 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@testlabauto testlabauto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dhruvisompura
dhruvisompura reviewed May 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@dhruvisompura dhruvisompura left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to update the alt text for these screenshots on the docs pages since they show a different Python version in the new screenshots (we reference Python 3.12.11 (Pyenv) but the new screenshots show Python 3.10.20 (Venv: .venv)).

@midleman midleman mentioned this pull request May 20, 2026
Open
@midleman
Copy link
Copy Markdown
Contributor Author

midleman commented May 20, 2026 •
edited
Loading

We will need to update the alt text for these screenshots on the docs pages since they show a different Python version in the new screenshots (we reference Python 3.12.11 (Pyenv) but the new screenshots show Python 3.10.20 (Venv: .venv)).

I can either adjust the screenshot... or we can adjust the alt text. If you have a preference let me know! I use Venv: .venv on other screens per @juliasilge request - so I just assumed we wanted to be consistent?

@dhruvisompura
Copy link
Copy Markdown
Contributor

dhruvisompura commented May 20, 2026

We will need to update the alt text for these screenshots on the docs pages since they show a different Python version in the new screenshots (we reference Python 3.12.11 (Pyenv) but the new screenshots show Python 3.10.20 (Venv: .venv)).

I can either adjust the screenshot... or we can adjust the alt text. If you have a preference let me know! I use Venv: .venv on other screens per @juliasilge request - so I just assumed we wanted to be consistent?

I don't have a strong preference. Let's update the alt text then if we know we want to use venv!

juliasilge
juliasilge approved these changes May 21, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@juliasilge juliasilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good, and we'll need to make some minor adjustments to how we load these up into the context anyway so no big deal to change the alt text as well. I do think showing .venv is a nice, expected, non-controversial choice.

@midleman midleman merged commit 24c9d5a into main May 21, 2026
28 checks passed
@midleman midleman deleted the mi/release-screenshots-3 branch May 21, 2026 10:56
@github-actions github-actions Bot locked and limited conversation to collaborators May 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dhruvisompura dhruvisompura dhruvisompura left review comments

@juliasilge juliasilge juliasilge approved these changes

@testlabauto testlabauto testlabauto approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@midleman @dhruvisompura @juliasilge @testlabauto