e2e: migrate snippets + variables + active interpreter release screenshots#13672
Open
midleman wants to merge 14 commits into
Open
e2e: migrate snippets + variables + active interpreter release screenshots#13672midleman wants to merge 14 commits into
midleman wants to merge 14 commits into
Conversation
- Positron notebook: kernel selector, assistant action bar, assistant panel - Jupyter notebook: kernel selector Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…nshot Air ships pre-installed in some builds but not all. Install it when the Install button is visible so the capture shows the Disable/Uninstall state every run. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Target the .kernel-action-view-item container so the codicon-notebook-kernel-select icon stays inside the red box, matching the existing published screenshot. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Render the 4 notebook screenshots at 960x640 and composite each capture onto a white canvas with a soft drop shadow to approximate the floating-window look of the legacy macOS-chrome screenshots. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Clip the screenshot to a 24px-radius rounded rect before drawing the drop shadow so the shadow traces the rounded silhouette. - Add overrideWorkspaceName helper to rewrite the title bar and top action bar folder picker, mapping qa-example-content -> positron-demos-notebooks on the 4 notebook captures. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Extend overrideRuntimeLabel to also target the Positron notebook kernel status badge and the VS Code Jupyter kernel chip, so the captured label reads "Python <ver> (Venv: .venv)" instead of leaking the runner's Python manager (Pyenv, VirtualEnvWrapper, uv, etc.). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Apply the rounded-corner drop shadow inside captureFullWindow itself so all full-app screenshots get the floating-window treatment automatically (astropy, the four notebook captures, and any future full-window shots). Partial captures via capturePanel/captureRegion are unaffected. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Add extensions.installFromEditorIfNotInstalled() and use it from extension-publisher screenshot test. - Use notebooksPositron.expectAssistantButtonsVisible() and clickAskAssistantButton() instead of raw locators in the notebook assistant screenshot tests. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds snippets-configure-snippets, snippets-configure-language-specific-snippets, snippets-for-example, and snippets-keyword-with-two-items.
Two R-session screenshots: variables-pane.png (R with several variables assigned, Variables view focused) and active-interpreter-session.png (R + Python running, Sessions view focused, top-right chip annotated).
|
E2E Tests 🚀 |
- aria-label format is `lang, (Display)` (with comma), not `lang (Display)` - monaco-list virtualization needs wheel-scroll, not scrollTop - R completions require a running R session — add the `r` fixture - Trigger suggest with Ctrl+Space; press again to expand the details panel - Details panel class is `.suggest-details-container`, not `.details` - Capture union of suggest widget + details panel for the `for` snippet
…lity Mouse-wheel didn't trigger virtualized list scroll in Linux CI. Switch to ArrowDown navigation and wait for python/quarto/r to all be rendered together (the virtualized window only holds ~20 rows, so the bottom of the visible range needs to clear past r before all three are present in the DOM).
Drop the redundant python session and shorten the panel so the Sessions view sits higher in the auxiliary side bar.
Starting R once via the fixture in every test lets `sessions.start({ reuse: true })`
short-circuit consistently and avoids re-triggering the session quick-pick
mid-suite (a known flake surface).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds six release screenshots, stacked on #13651.
forsnippet with details panel)funandfunctionrows annotated)QA Notes
Depends on #13651 (uses
overrideWorkspaceName, auto-shadow oncaptureFullWindow).