test: regression guard for renderer stack popup disposal#13675
Open
rodrigosf672 wants to merge 2 commits into
Open
test: regression guard for renderer stack popup disposal#13675rodrigosf672 wants to merge 2 commits into
rodrigosf672 wants to merge 2 commits into
Conversation
Add vitest coverage for popup-inside-dialog disposal path (previously untested). Test exposed missing bounds registration in PositronModalDialog -- fixed inline. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
E2E Tests 🚀 |
…smisses When a dropdown popup inside a dialog detects a click outside the entire renderer stack, it previously called disposeAll(), which also destroyed the parent dialog. Add hasPersistentParent() to detect when a dialog (renderer with registered bounds) exists below the popup on the stack, and in that case only dispose the popup itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PositronModalDialog-- fixed inlineTests
npx vitest run src/vs/base/test/browser/positronModalReactRenderer.vitest.tsccc2aaa4.@:new-folder-flow @:modal