Quadratic symbolic expression only #2647
Merged
+1,020
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make variable generic.
…r-labs/powdr into quadratic_symbolic_expression
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
executor/src/witgen/jit/symbolic_expression.rs:141
- [nitpick] The method compute_updated uses operator matching for both 'Sub' and 'Add' with negation. Consider using explicit subtraction to improve clarity, unless operator overloading for '-' is definitively the intended behavior.
match op {
executor/src/witgen/jit/symbolic_expression.rs:116
- New branches introduced in compute_updated and apply_update would benefit from added test cases to verify that all update scenarios and operator overloading behaviors work as expected.
/// Applies a variable update and returns a modified version if there was a change.
| SymbolicExpression::Concrete(_) => None, | ||
| SymbolicExpression::Symbol(v, _) => { | ||
| if *v == variable_update.variable { | ||
| assert!(variable_update.known); |
There was a problem hiding this comment.
Using an assert here may lead to a runtime panic in production if variable_update.known is false. Consider handling this case more gracefully, for example by returning an error or a None value with a proper log message.
Suggested change
| assert!(variable_update.known); | |
| if !variable_update.known { | |
| // Log a message or handle the error gracefully if needed. | |
| return None; | |
| } |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
chriseth
commented
Apr 10, 2025
| }; | ||
| match op { | ||
| BinaryOperator::Add => Some(l + r), | ||
| BinaryOperator::Sub => Some(l + -r), |
There was a problem hiding this comment.
Could use l - r here now
georgwiese
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.