Add hashed configs to pod annotations #469
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
Purpose of the change
Fixes #454
What the code does
Add hashed zookeeper configuration as the pod annotation in the statefulSet.
The makeZkPodAnnotations function computes the hash for the zookeeper config string and calls mergeAnnotations to merge with the annotations from the CR.
There are several possible improvements regarding the patch:
mergeAnnotations
function encodes the same logic as themergeLabels
function, we could reduce these two into a generalmergeMap
function to reduce the code redundency.env.sh
could reflect to the zookeeper cluster without a restart. If that also requires a restart, then we can add the hash of result ofmakeZkEnvConfigString
to the annotation map too.How to verify it
Similar to the steps mentioned in #454