Skip to content

Conversation

@idolaman
Copy link

Change log description

Adds the option to use external ZooKeeper in ClientService

Purpose of the change

Fixes #572

What the code does

The code uses the same logic as AdminServerService boolean external field. in ClientService, to expose client-service outside
the cluster, using LoadBalancer service type.

How to verify it

System tests must pass, when clientService.external is true, client service in kubernetes type needs to be LoadBalancer (this test added).

@idolaman idolaman force-pushed the external-option-client-service branch from 9df5502 to 2ca1a87 Compare November 21, 2023 09:16
@codecov
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (28d1f69) 85.12% compared to head (2ca1a87) 85.13%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #576      +/-   ##
==========================================
+ Coverage   85.12%   85.13%   +0.01%     
==========================================
  Files          12       12              
  Lines        1613     1615       +2     
==========================================
+ Hits         1373     1375       +2     
  Misses        155      155              
  Partials       85       85              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@almogtavor
Copy link

@anishakj can you check this out? This is a quite needed feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Zk clientservice cannot be declared external

3 participants