Vitest migration #709
Open
Vitest migration #709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: -7.01 kB (-6.57%) ✅ Total Size: 99.7 kB
ℹ️ View Unchanged
|
JoviDeCroock
force-pushed
the
vitest-migration
branch
from
633f243 to
25f4e01
Compare
|
CI of these will fail right now because it seems vite requires node 20+ we might have to downgrade vite for now, presumably the previous major worked on 18.x |
|
this should be good now! we just need to catch it up from main |
Adds vitest and associated scripts which will not succeed yet, as we have no projects.
We were quickly going to end up with too many sub-configs, and all sorts of problems with extending the various configs. This switches to a single root config which globs each of the monorepo packages instead.
* test: migrate preact/utils to vitest This also adds `preact/utils` to the pnpm workspace so it can be resolved properly via `@preact/signals-utils`. * chore: revert workspace change * fix: downgrade to vite 6 and revert the revert
Migrates the signals package to use vitest browser tests.
Migrates the core package to use vitest.
JoviDeCroock
force-pushed
the
vitest-migration
branch
from
be8f7f8 to
d1975d7
Compare
* test: migrate react tests to vitest * test: migrate react-transform to vitest * chore: remove mocha/sinon/chai/karma * fix: add exact import * fix: strongly type mocked components * test: add the sketchy transform back * fix: funky runtime path * fix: resolve signals after runtime * test: map things to places * test: use vitest aliases THIS MAY ACTUALLY WORK! * chore: use react 16 in runtime too
* chore: remove unused karma config * test: correct coverage globs
* chore: de-dupe babel dependencies In the lockfile, we ended up with two versions of babel. This is basically de-duping and dropping one of them. * fix: use vitest assertions * fix: dedupe vite * test: use cdp to force garbage collection
|
It builds! Amazing. Now we just need to figure out how to land it 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds vitest and associated scripts which will not succeed yet, as we have no projects.