New Adapter: Velonium - Limelight Alias #3840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoxaAntoxic
previously approved these changes
Mar 27, 2025
|
pls resolve conflicts |
|
@osulzhenko The conflict comes from the fact that I create a new PR for every LightDigital alias. |
# Conflicts: # src/main/resources/bidder-config/limelightDigital.yaml # src/test/resources/org/prebid/server/it/test-application.properties
| @@ -313,6 +313,8 @@ adapters.limelightDigital.aliases.streamvision.enabled=true | |||
| adapters.limelightDigital.aliases.streamvision.endpoint=http://localhost:8090/streamvision-exchange/{{Host}}/{{PublisherID}} | |||
| adapters.limelightDigital.aliases.orangeclickmedia.enabled=true | |||
| adapters.limelightDigital.aliases.orangeclickmedia.endpoint=http://localhost:8090/orangeclickmedia-exchange/{{Host}}/{{PublisherID}} | |||
| adapters.limelightDigital.aliases.velonium.enabled=true | |||
| adapters.limelightDigital.aliases.velonium.endpoint=http://localhost:8090/velonium-exchange/{{Host}}/{{PublisherID}} | |||
There was a problem hiding this comment.
macros are redundant since it's not covered in the test, please remove
AntoxaAntoxic
previously approved these changes
Apr 23, 2025
CTMBNara
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
#3822