feat: Distributed Procedure Support Part 3/X - native part changes #26375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @hantangwangd, your pull request is larger than the review limit of 150000 diff characters
hantangwangd
changed the title
hantangwangd
force-pushed
the
support_call_distributed_procedure_part3
branch
from
db906b2 to
b59a17f
Compare
And expose the procedure registry to the `presto-analyzer` and `connectors` module
Refactor `Procedure` and `DistributedProcedure` into abstract classes. Use a subclass `TableDataRewriteDistributedProcedure` for table rewrite tasks, for example, merge small data files, sort table data, repartition table data etc. And introduce a new class `LocalProcedure` to represent the former coordinator-only procedures. Rename `IProcedureRegistry` to `ProcedureRegistry`, and accordingly rename previous `ProcedureRegistry` to `BuiltInProcedureRegistry`.
hantangwangd
force-pushed
the
support_call_distributed_procedure_part3
branch
from
b59a17f to
34f0586
Compare
hantangwangd
force-pushed
the
support_call_distributed_procedure_part3
branch
from
34f0586 to
4a75c9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[WIP]: wait for the previous two parts to be merged.
This PR is the third part of many PRs to support distributed procedure into Presto. It is a split of the original entire PR which is located here: #22659.
The whole work in this PR includes the necessary presto c++ protocol and native changes to support calling distributed procedures in native workers.
Motivation and Context
prestodb/rfcs#12
Impact
N/A
Test Plan
N/A
Contributor checklist
Release Notes