Skip to content

Conversation

@aditi-pandit
Copy link
Contributor

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* ... 
* ... 

Hive Connector Changes
* ... 
* ... 

If release note is NOT required, use:

== NO RELEASE NOTE ==

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Oct 21, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 21, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR advances the Velox submodule to the latest upstream commit, updates build and configuration scripts to accommodate new dependencies, and adapts native and JNI integration code to match updated Velox APIs.

File-Level Changes

Change Details Files
Bump Velox submodule to latest commit
  • Update VERSION file with new tag
  • Advance .gitmodules pointer to new Velox SHA
  • Remove obsolete local patches
presto-native-execution/velox/VERSION
.gitmodules
Revise CMake build scripts for new dependencies
  • Add folly and fmt include paths
  • Link against updated Velox dependencies
  • Set C++17 standard flag explicitly
presto-native-execution/velox/CMakeLists.txt
presto-native-execution/velox/BuildVelox.cmake
Adapt native integration code to Velox API changes
  • Replace deprecated Buffer API with Vector encoding
  • Adjust memory pool initialization to new QueryContext signature
  • Update batch reading logic to use latest RowContainer methods
presto-native-execution/src/native/NativeExecutionManager.cpp
presto-native-execution/src/native/RowBatchReader.cpp
Regenerate and update JNI bindings
  • Regenerate VeloxBindings.java with new method signatures
  • Update JNI helper to match changed initialization parameters
  • Handle new exception types thrown by Velox
presto-native-execution/src/main/java/com/facebook/presto/velox/VeloxBindings.java
presto-native-execution/src/native/jni/VeloxJni.cpp
Refresh native tests for compatibility
  • Update expected output in vector encoding tests
  • Add new tests for recent Velox functions
  • Remove tests targeting deprecated APIs
presto-native-execution/src/test/native/TestVectorEncoding.cpp
presto-native-execution/src/test/native/TestMemoryPool.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@aditi-pandit aditi-pandit changed the title chore(native): Advance Velox [Do not review]chore(native): Advance Velox Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants