fix: Set default kExchangeMaxErrorDuration to be > maxMemoryArbitrationTime

[jaystarshot]

We have seen issues in production due to

Failed to fetch data from xxx /v1/task/20251016_061652_01883_is2sk.9.0.9.0/results/17/74 - Exhausted after 1 retries, duration 206279ms: proxygen::HTTPException: Shutdown transport: EOF, 10.154.225.18:8080 Operator: Exchange[3877]

206279ms is roughly 3 min. Arbitrator timeout is 5m

Detailed investigation revealed that these errors occurred during high memory usage scenarios. Some stages were blocked waiting for memory arbitration, and while arbitration was pending, downstream tasks timed out when fetching data from upstream, resulting in the above exchange errors.

Fix

We increased the exchange error timeout to exceed the memory arbitrator’s activation duration. This prevents premature exchange failures caused by arbitration delays.

Note

This change does not address the underlying memory usage or query inefficiencies. It simply ensures that failures now correctly reflect memory pressure issues (e.g., lack of spilling or arbitration tuning) rather than misleading exchange errors.

There is also kExchangeRequestTimeout and kExchangeConnectTimeout but don't think they are respected in this case cause you can clearly see there was only 1 retry done in the error in 3 mins whereas we had values to set to 20sec

== RELEASE NOTES ==

Hive Connector Changes

• set default value of kExchangeMaxErrorDuration to 6m

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR adjusts the default exchange error timeout to exceed the maximum memory arbitration duration, preventing misleading exchange failures under high memory pressure.

Entity relationship diagram for updated SystemConfig property

erDiagram
    SYSTEM_CONFIG {
        string kExchangeMaxErrorDuration
    }
    SYSTEM_CONFIG ||--|| EXCHANGE : configures
    EXCHANGE {
    }

Loading

Class diagram for updated SystemConfig default value

classDiagram
    class SystemConfig {
        +string kExchangeMaxErrorDuration = "6m"
        +constructor SystemConfig()
        -- other properties and methods --
    }

Loading

File-Level Changes

Change	Details	Files
Increase default kExchangeMaxErrorDuration from 3 minutes to 6 minutes	Changed STR_PROP(kExchangeMaxErrorDuration) default value from "3m" to "6m"	presto-native-execution/presto_cpp/main/common/Configs.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[steveburnett]

Thanks for the release note! Suggested rephrasing so that the entry begins with a keyword in the Order of changes in the Release Notes Guidelines.

If this rephrasing doesn't accurately describe your work, please revise.

== RELEASE NOTES ==

Hive Connector Changes

* Fix exchange errors by setting the default value of ``kExchangeMaxErrorDuration`` to 6m.

[aditi-pandit]

@jaystarshot : Thanks for this change. I am in agreement that it is worth making this greater than maxArbitrationTime, but I feel 6 mins is a long duration as well. Do you feel its worth reducing maxArbitrationTime to 4 mins and increase exchangeMaxErrorDuration to 5 mins ?