[Codemod][ThriftAnnotationsFBSource] fbcode/github/

[sadroeck]

Differential Revision: D86087872

[linux-foundation-easycla]

• ❌ The email address for the commit (ff9b5b3) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Introduces standard Thrift annotation includes and replaces inline annotation parameters on the ExecutionFailureInfo.cause field with explicit @cpp.Ref and @thrift.DeprecatedUnvalidatedAnnotations attributes.

File-Level Changes

Change	Details	Files
Add annotation includes to Thrift files	Include thrift/annotation/cpp.thrift Include thrift/annotation/thrift.thrift	presto-native-execution/presto_cpp/main/thrift/presto_thrift.thrift presto-native-execution/presto_cpp/main/thrift/temp_presto_thrift.thrift
Migrate inline annotations to new attribute syntax on ExecutionFailureInfo.cause	Remove old inline cpp.ref_type and drift.recursive_reference parameters Add @cpp.Ref with type=cpp.RefType.SharedMutable Add @thrift.DeprecatedUnvalidatedAnnotations with drift.recursive_reference in items	presto-native-execution/presto_cpp/main/thrift/presto_thrift.thrift presto-native-execution/presto_cpp/main/thrift/temp_presto_thrift.thrift

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• Consolidate identical codemod changes across presto_thrift.thrift and temp_presto_thrift.thrift (or remove the temp file) to avoid duplicated maintenance overhead.
• Consider factoring out the repeated thrift/annotation includes into a common header or including them only where needed to reduce redundancy.
• Plan to migrate drift.recursive_reference out of DeprecatedUnvalidatedAnnotations into a proper validated annotation to avoid future deprecation issues.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consolidate identical codemod changes across presto_thrift.thrift and temp_presto_thrift.thrift (or remove the temp file) to avoid duplicated maintenance overhead.
- Consider factoring out the repeated thrift/annotation includes into a common header or including them only where needed to reduce redundancy.
- Plan to migrate drift.recursive_reference out of DeprecatedUnvalidatedAnnotations into a proper validated annotation to avoid future deprecation issues.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}