Skip to content

feat: Add max_split_preload_per_driver to java system config #26589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Add max_split_preload_per_driver to java system config #26589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions presto-main-base/src/main/java/com/facebook/presto/SystemSessionProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ public final class SystemSessionProperties
public static final String IGNORE_STATS_CALCULATOR_FAILURES = "ignore_stats_calculator_failures";
public static final String PRINT_STATS_FOR_NON_JOIN_QUERY = "print_stats_for_non_join_query";
public static final String MAX_DRIVERS_PER_TASK = "max_drivers_per_task";
public static final String MAX_SPLIT_PRELOAD_PER_DRIVER = "max_split_preload_per_driver";
public static final String MAX_TASKS_PER_STAGE = "max_tasks_per_stage";
public static final String DEFAULT_FILTER_FACTOR_ENABLED = "default_filter_factor_enabled";
public static final String CTE_MATERIALIZATION_STRATEGY = "cte_materialization_strategy";
Expand Down Expand Up @@ -1024,6 +1025,11 @@ public SystemSessionProperties(
false,
value -> min(taskManagerConfig.getMaxDriversPerTask(), validateNullablePositiveIntegerValue(value, MAX_DRIVERS_PER_TASK)),
object -> object),
integerProperty(
MAX_SPLIT_PRELOAD_PER_DRIVER,
"Maximum number of splits to preload per driver. Set to 0 to disable preloading",
Copy link
Contributor

@sourcery-ai sourcery-ai bot Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Clarify behavior for negative values in the property description.

If negative values are invalid, please update the description to explicitly state this.

Suggested change
"Maximum number of splits to preload per driver. Set to 0 to disable preloading",
"Maximum number of splits to preload per driver. Must be zero or positive. Set to 0 to disable preloading. Negative values are not allowed.",

0,
false),
booleanProperty(
IGNORE_STATS_CALCULATOR_FAILURES,
"Ignore statistics calculator failures",
Expand Down Expand Up @@ -2584,6 +2590,11 @@ public static OptionalInt getMaxDriversPerTask(Session session)
return OptionalInt.of(value);
}

public static int getMaxSplitPreloadPerDriver(Session session)
{
return session.getSystemProperty(MAX_SPLIT_PRELOAD_PER_DRIVER, Integer.class);
}

public static int getMaxTasksPerStage(Session session)
{
return session.getSystemProperty(MAX_TASKS_PER_STAGE, Integer.class);
Expand Down
Loading