Skip to content

Commit

Permalink
Fix fails
Browse files Browse the repository at this point in the history
  • Loading branch information
nickschuch committed Feb 27, 2024
1 parent 8db04b3 commit 331d8b7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion performance-testing/scenarios/basic.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export default function () {
let res = http.get(http.url`${baseURL}/en/articles?cache-buster=${cb}`)
if (
!check(res, {
'status code MUST be 200': (res) => res.status == 200,
'ok': (res) => res.status == 200,
})
) {
fail('status code was *not* 200');
Expand Down
4 changes: 2 additions & 2 deletions performance-testing/scripts/review_results.sh
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ if [[ "${BASH_SOURCE[0]}" = "$0" ]]; then

info "Starting performance review..."

fails_baseline=$(cat ${BASELINE_FILE} | jq -r .metrics.http_req_duration.avg)
fails_otel=$(cat ${OTEL_FILE} | jq -r .metrics.http_req_duration.avg)
fails_baseline=$(cat ${BASELINE_FILE} | jq -r .root_group.checks.ok.fails)
fails_otel=$(cat ${OTEL_FILE} | jq -r .root_group.checks.ok.fails)

# Convert to integer.
fails_baseline=${fails_baseline%.*}
Expand Down

0 comments on commit 331d8b7

Please sign in to comment.