Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance (datatable): limiting re-render for only radiobutton/checkbox cells at row selection #7425

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
32c279f
Improved performance of DataTable by adding conditions for when the B…
acc-cassio Nov 13, 2024
2deb046
Created selectiveCompare function to assist components' memoization
acc-cassio Nov 13, 2024
8f8272f
Simplified BodyCell props parsing in BodyRow.js
acc-cassio Nov 13, 2024
cc62cdc
Calculation of selected state for BodyCell being done in the BodyRow …
acc-cassio Nov 13, 2024
501dfe2
Fixed performance issue of Datatable related to cell/row selection, b…
acc-cassio Nov 14, 2024
1f4e887
Further performance improvements to BodyRow.js
acc-cassio Nov 15, 2024
bb46731
Fixed bug related to the MetaKeySelection in TableBody.js
acc-cassio Nov 15, 2024
0d11c7b
Bug fixing in BodyRow.js
acc-cassio Nov 15, 2024
f83a0e8
Shifted functions helper functions selectiveCompare, absoluteCompare …
acc-cassio Nov 15, 2024
277cdc4
Shifted several functions from BodyCell.js to BodyRow.js so that they…
acc-cassio Nov 16, 2024
f0c037c
Logging msg
acc-cassio Nov 16, 2024
36144eb
Shifted column props calculation to TableBody since it is an expensiv…
acc-cassio Nov 16, 2024
3372392
Renamed the BodyCell to Cell and split it in two parts: BodyCell and …
acc-cassio Nov 16, 2024
c0e676e
Removed console.log in DataTable.js
acc-cassio Nov 16, 2024
c5b10be
Ran prettier in changed files
acc-cassio Nov 17, 2024
e72a51a
Fixed minor bug in createLoading and lint error by unwrapping functio…
acc-cassio Nov 18, 2024
60b1af7
Minor bug fixing in absoluteCompare util function
acc-cassio Dec 1, 2024
f21132e
Removed redudant memoization of Cell
acc-cassio Jan 18, 2025
a796c60
Added key to Cell at mapping
acc-cassio Jan 18, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading