Skip to content

refactor: Address code review feedback for checkout components #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Parent: feature: Checkout Components
wants to merge 2 commits into
base: bn/feature/checkout-components
Choose a base branch
from
Open

refactor: Address code review feedback for checkout components #1378

wants to merge 2 commits into from

Conversation

@OnurVar
Copy link
Contributor

@OnurVar OnurVar commented Oct 13, 2025

#1376

  • Extract stateless helper methods into DesignTokensProcessor utility
  • Replace NSError with PrimerError for token loading failures
  • Use guard statement for early returns in reference resolution
  • Rename loop variable from 'op' to 'symbol' for clarity
  • Remove unnecessary parentheses in operator array

@OnurVar
refactor: Address code review feedback for checkout components
02f5c86 
- Extract stateless helper methods into DesignTokensProcessor utility
- Replace NSError with PrimerError for token loading failures
- Use guard statement for early returns in reference resolution
- Rename loop variable from 'op' to 'symbol' for clarity
- Remove unnecessary parentheses in operator array
@OnurVar OnurVar self-assigned this Oct 13, 2025
@OnurVar OnurVar marked this pull request as ready for review October 13, 2025 16:43
@OnurVar OnurVar requested a review from a team as a code owner October 13, 2025 16:43
@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2025 •
edited
Loading

Warnings
⚠️ This PR doesn't seem to contain any updated Unit Test 🤔. Please consider double checking it.🙏

Generated by 🚫 Danger Swift against e6c10ec

@github-actions
Copy link
Contributor

Appetize link: https://appetize.io/app/z6kovxlt4vi4qhhehazdhkuew4

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
17.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@borisprimer borisprimer borisprimer approved these changes

@henry-cooper-primer henry-cooper-primer henry-cooper-primer approved these changes

Assignees

@OnurVar OnurVar

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@OnurVar @borisprimer @henry-cooper-primer