Update a11y-use-next-tooltip to be a11y-use-accessible-tooltip and make the changes accordingly #270
Conversation
… bundle and the old one from deprecated
🦋 Changeset detectedLatest commit: 4cb5e97 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| const rootImport = sourceCode.ast.body.find(statement => { | ||
| return statement.type === 'ImportDeclaration' && statement.source.value === '@primer/react' | ||
| }) |
There was a problem hiding this comment.
Wondering if there's a reason we can't reuse the rootImport from line 43 here?
There was a problem hiding this comment.
We can re-use! I missed that due to using the wrong method (filter vs find.) I updated the code 🤗 Thanks for catching that.
The rule is currently off at dotcom - we haven't started using it yet so thankfully no need to update a bunch of line etc. However I caught 2 usages in the helphub so these need to be updated. I'll mark this as major so that we can communicate this change. |
Since Tooltip v2 is now exported from
@primer/reactbundle and Tooltip v1 from@primer/react/deprecated, this PR updates the code accordingly and renames the rule.