Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update typescript to 5.8, enable erasableSyntaxOnly #5745

Merged
merged 1 commit into from
Mar 13, 2025
Merged

chore(deps): update typescript to 5.8, enable erasableSyntaxOnly #5745

merged 1 commit into from
Mar 13, 2025

Conversation

joshblack
Copy link
Member

Update TypeScript to v5.8 and enable the erasableSyntaxOnly option in tsconfig.base.json

Changelog

New

Changed

  • Update package.json to include [email protected]
  • Add erasableSyntaxOnly to tsconfig.base.json

Removed

Rollout strategy

  • None; if selected, include a brief description as to why

@joshblack joshblack requested a review from a team as a code owner March 8, 2025 01:36
@joshblack joshblack requested a review from jonrohan March 8, 2025 01:36
@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Mar 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@joshblack joshblack added the skip changeset This change does not need a changelog label Mar 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 106.02 KB (0%)
packages/react/dist/browser.umd.js 106.42 KB (0%)

siddharthkp
siddharthkp approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joshblack joshblack added this pull request to the merge queue Mar 13, 2025
Merged via the queue into main with commit 4cd9148 Mar 13, 2025
50 of 51 checks passed
@joshblack joshblack deleted the chore/update-typescript-5.8 branch March 13, 2025 18:38
hectahertz pushed a commit that referenced this pull request Mar 20, 2025
@joshblack @hectahertz
chore(deps): update typescript to 5.8, enable erasableSyntaxOnly (#5745)
caee055
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddharthkp siddharthkp siddharthkp approved these changes

@jonrohan jonrohan Awaiting requested review from jonrohan jonrohan is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshblack @siddharthkp