-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SelectPanel: Make panel full screen on narrow screens with Save and optional Cancel button #5761
Conversation
🦋 Changeset detectedLatest commit: 12fb61b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
1 similar comment
This comment was marked as duplicate.
This comment was marked as duplicate.
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/367822 |
🟢 golden-jobs completed with status |
Note
Save
button on narrow screens which callsonClose('click-outside')
to simulate wide screen behavioronCancel
prop that renders aCancel
button on narrow which callsonClose('escape')
narrow-selectpanel.mov
With
onCancel
prop:selectpanel-cancel.mov
Rollout strategy
Testing & Reviewing
Merge checklist