Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectPanel: Make panel full screen on narrow screens with Save and optional Cancel button #5761

Merged
merged 30 commits into from
Mar 20, 2025

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Mar 11, 2025

Note


  • Closes https://github.com/github/primer/issues/4109
  • Implements Save button on narrow screens which calls onClose('click-outside') to simulate wide screen behavior
  • Accept onCancel prop that renders a Cancel button on narrow which calls onClose('escape')
narrow-selectpanel.mov

With onCancel prop:

selectpanel-cancel.mov

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Mar 11, 2025

🦋 Changeset detected

Latest commit: 12fb61b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Mar 11, 2025
@siddharthkp siddharthkp changed the base branch from main to responsive-anchored-overlay March 11, 2025 16:03
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Mar 11, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@siddharthkp siddharthkp changed the title SelectPanel: Make panel full screen on narrow screens SelectPanel: Make panel full screen on narrow screens with Save button Mar 11, 2025
Copy link
Contributor

github-actions bot commented Mar 11, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 106.09 KB (+0.18% 🔺)
packages/react/dist/browser.umd.js 106.48 KB (+0.32% 🔺)

@siddharthkp siddharthkp self-assigned this Mar 11, 2025
@github-actions github-actions bot requested a deployment to storybook-preview-5761 March 11, 2025 16:08 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-5761 March 11, 2025 16:22 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Mar 11, 2025
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh labels Mar 18, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-5761 March 18, 2025 21:04 Inactive
@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Mar 18, 2025
Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ yayy, looks great!
smaaaaall nit: if we could add onCancel to our singleSelect story so that the close button shows I think that'd be great. Just realized there's no way to close the panel without changes 🙏
image

@siddharthkp siddharthkp enabled auto-merge (squash) March 19, 2025 11:02
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Mar 19, 2025
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

1 similar comment

This comment was marked as duplicate.

@github-actions github-actions bot requested a deployment to storybook-preview-5761 March 19, 2025 11:06 Abandoned
@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Mar 19, 2025
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/367822

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@siddharthkp siddharthkp disabled auto-merge March 20, 2025 16:59
@siddharthkp siddharthkp enabled auto-merge (squash) March 20, 2025 16:59
@siddharthkp siddharthkp disabled auto-merge March 20, 2025 20:42
@siddharthkp siddharthkp added this pull request to the merge queue Mar 20, 2025
Merged via the queue into main with commit 94bc6e4 Mar 20, 2025
44 checks passed
@siddharthkp siddharthkp deleted the selectpanel-responsive-save-button branch March 20, 2025 20:54
@primer primer bot mentioned this pull request Mar 20, 2025
TylerJDev added a commit that referenced this pull request Mar 27, 2025
…ve and optional Cancel button (#5761)"

This reverts commit 94bc6e4.
@siddharthkp siddharthkp mentioned this pull request Mar 28, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants