-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Modal variant with declarative buttons to PRC SelectPanel #5883
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 9960bf2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
Co-authored-by: Siddharth Kshetrapal <[email protected]>
500510a
to
94ed190
Compare
@francinelucca All comments from #5817 have been addressed here, can I please have a review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking very good! Minor observation around styling and also I think we should add some testing in the selectPanel.
some recommendations:
- The selections render as radios when variant modal and single select
- The save and oncancel buttons are present when variant modal
Let's also run integration checks and get CI to green 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the radios are looking too close together here. Seeing the same in the deployment:
size-limit report 📦
|
Note
This is a remake of #5817 to expedite merging to main.
Closes https://github.com/github/primer/issues/4106
Changelog
New
Adds the
modal
variant toSelectPanel
, complete withRadio
icons.Single select modal
Screen.Recording.2025-04-06.at.18.21.19.mov
Multi select modal
Screen.Recording.2025-04-06.at.18.23.07.mov
See #5817 for all the context.
Shortcut
We are still using
AnchoredOverlay
underneath. But, forvariant=modal
, we override its position by directly passingtop
,left
, etc. tooverlayProps
going down to the OverlayThe ideal super clean solution would have been to refactor SelectPanel and conditionally use
useAnchoredPosition
instead of AnchoredOverlay for variant=anchored. Something @siddharthkp attempted in #5230 earlier but had to revert.Rollout strategy
Testing & Reviewing
Merge checklist