Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental support for Azure managed service identities #4680

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

richardbarrell-calvium
Copy link

Related to #12562, I happen to need support for Azure managed service identities.

I believe that the feature which #12562 is asking for should be extremely similar to this, because that also involves sending a HTTP request to a local endpoint and then creating a token from that.

Please note TODOs in quaint/src/connector/mssql/native/mod.rs:

  • I'm not certain that this is the right place to fix this problem, maybe I should have put the change in tiberius instead?
  • these tokens do expire; currently I have no mechanism to refresh them

@richardbarrell-calvium richardbarrell-calvium requested a review from a team as a code owner January 29, 2024 20:43
@richardbarrell-calvium richardbarrell-calvium requested review from laplab and Druue and removed request for a team January 29, 2024 20:43
@CLAassistant
Copy link

CLAassistant commented Jan 29, 2024

CLA assistant check
All committers have signed the CLA.

@richardbarrell-calvium
Copy link
Author

Just thinking aloud here:

  1. Maybe a better implementation would be to use https://crates.io/crates/azure_identity/0.19.0/dependencies instead of raw reqwest to construct these requests and headers.
  2. I'm not sure how to make a unit test work for this feature (i.e. against a locally running copy of SQL server in a docker container) because this relies on a bunch of MS Entra (recently renamed from Azure Active Directory) stuff.

@SevInf SevInf added the PR: Feature A PR That introduces a new feature label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Feature A PR That introduces a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants