Support Custom Solver Block#1024
Draft
jijn wants to merge 8 commits into
Draft
Conversation
jijn
force-pushed
the
custom_solver
branch
2 times, most recently
from
bb7452a to
6cd854c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
new feature
What is the current behavior? (You can also link to an open issue here)
Support solve type: Constant, Explicit, Linear, Newton
What is the new behavior (if this is a feature change)?
Add a new solve type:
CustomSolverThis gives users the flexibility to implement their own solver block. As a demonstration, I included an application for the mass-conserved Allen–Cahn equation. Right now, I override
solve_level, but we could also usesolve. Please let me know what you think and if you have any suggestions.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
The result shows that the constraint is correctly imposed::