Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use react-redux hooks in Toast component #2043

Merged
merged 5 commits into from
Mar 9, 2023

Conversation

lindapaiste
Copy link
Collaborator

Related to issues #1458 & #2042

Changes:

  • Refactor the Toast component to use react-redux hooks instead of the connect HOC, in line with Redux best practices.
  • Handle the isVisible check inside of the Toast component itself instead of in the parent. This means that we only need one if instead of three, and the parents no longer need to access any toast state from the store.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@welcome
Copy link

welcome bot commented Jul 19, 2022

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

Copy link
Contributor

@3ru 3ru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:+1:

@release-com
Copy link

release-com bot commented Aug 2, 2022

Release Environments

This pull request environment is provided by Release, learn more!
To see the status of the environment click on Environment Status below.

  • p5.js-web-editor

🔧Environment Status : https://app.releasehub.com/public/Processing%20Foundation/env-67f58d76b5

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great :), thanks so much for your patience!

@raclim raclim merged commit 42ecd5d into processing:develop Mar 9, 2023
@lindapaiste lindapaiste deleted the refactor/redux-hooks branch August 8, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants