Added styled component to AddToCollectionList component #2368
Conversation
|
Hi @lindapaiste, I didn't see your PR #2353 before making this PR. I will make the changes later when you will merge the new code of AddCollectionList and AddCollectionSketchList components. We can put this as a potential fix as these styled components can be used in the new code. |
|
@adityagarg06 Sure thing. We can merge either my PR or yours first and then fix the conflicts that show up. Realistically your PR gets merged first. We have two components which are really similar (and it's confusing which is which!) but they both use these same two CSS classes which you converted. Maybe we do some sort of shared wrapper at some point, but for now I think you should If we want to make an improvement to the CSS while we're in here, how about we change it from: to: That will help a lot with responsiveness. |
|
|
||
| const projectInCollection = (project, collection) => | ||
| collection.items.find((item) => item.projectId === project.id) != null; | ||
|
|
||
| const CollectionAddSketchWrapper = styled.div` |
There was a problem hiding this comment.
| const CollectionAddSketchWrapper = styled.div` | |
| export const CollectionAddSketchWrapper = styled.div` |
|
|
||
| const projectInCollection = (project, collection) => | ||
| collection.items.find((item) => item.projectId === project.id) != null; | ||
|
|
||
| const CollectionAddSketchWrapper = styled.div` | ||
| &&& { | ||
| min-width: ${remSize(600)}; |
There was a problem hiding this comment.
| min-width: ${remSize(600)}; | |
| width: ${remSize(600)}; | |
| max-width: 100%; |
|
|
||
| const projectInCollection = (project, collection) => | ||
| collection.items.find((item) => item.projectId === project.id) != null; | ||
|
|
||
| const CollectionAddSketchWrapper = styled.div` | ||
| &&& { |
There was a problem hiding this comment.
It doesn't really matter but I suspect that you'd be fine without the &&&?
|
|
||
| const QuickAddWrapper = styled.div` | ||
| &&& { | ||
| min-width: ${remSize(600)}; |
There was a problem hiding this comment.
| min-width: ${remSize(600)}; | |
| width: ${remSize(600)}; | |
| max-width: 100%; |
Changes:
Added styled component to AddToCollectionList component.
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123