Skip to content

Fix: Searchbar class component to functional component #2403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix: Searchbar class component to functional component #2403

wants to merge 3 commits into from

Conversation

m-Chetan
Copy link

Changed Searchbar class component to functional component.

Ref #2358

@welcome
Copy link

welcome bot commented Sep 10, 2023

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@raclim
Copy link
Collaborator

raclim commented Mar 8, 2024

Thanks for opening this!

A few changes I might make here are using the arrow function definition on line 8, and potentially finding a way to compress the useEffect() hook on line 17. Since there's a few other pull requests that are refactoring the Searchbar component, so I'm going to close this for now, but please feel free to submit another PR!

@raclim raclim closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants