Skip to content

changed EmailVerificationView Component to functional component #2405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

Akhilbisht798
Copy link
Contributor

This pr is progress on issue #2358.

Changes:

  • Changes EmailVerificationVeiw component to functional Component

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@welcome
Copy link

welcome bot commented Sep 10, 2023

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@lindapaiste lindapaiste changed the title changed EmailVerificationVeiw Component to functional component changed EmailVerificationView Component to functional component Sep 13, 2023
Copy link
Collaborator

@lindapaiste lindapaiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lindapaiste
Copy link
Collaborator

If you are interested in doing any further cleanup of this component, here are some suggestions which you can put in an additional PR:

  • use useTranslation hook instead of withTranslation HOC
  • use react-redux hooks instead of connect HOC
  • access location from useLocation react-router hook
  • access browserHistory from useHistory react-router hook
  • turn the verificationTokenFromLocation function into a useMemo verificationToken variable

@lindapaiste lindapaiste merged commit 65d8798 into processing:develop Sep 13, 2023
@Akhilbisht798
Copy link
Contributor Author

@lindapaiste, Hey as you suggested clean up for this component can i do this directly wihtout opening a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants