Skip to content

Moved fileNode to be a functional component #2406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

yosuva-rv
Copy link

@yosuva-rv yosuva-rv commented Sep 10, 2023

Ref processing #2358

Changes:
Moved fileNode to be a functional component.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@welcome
Copy link

welcome bot commented Sep 10, 2023

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

Copy link
Collaborator

@lindapaiste lindapaiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There is definitely more cleanup which can be done in this component, but you've handled the function component conversion well.

@yosuva-rv
Copy link
Author

Looks good. There is definitely more cleanup which can be done in this component, but you've handled the function component conversion well.

Thanks @lindapaiste

@lindapaiste
Copy link
Collaborator

This PR will have the problem explained in this comment: #2524 (comment)

@raclim
Copy link
Collaborator

raclim commented Jun 13, 2024

Thanks for your work on this! Since it's been a while since this PR was submitted, some of its contents have fallen quite out of sync with the current develop branch so I'm going to close this for now. I'm sorry that we couldn't get this in, but please feel free to reopen this PR with any updates or check out our other issues!

@raclim raclim closed this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants